Skip to content

Conversation

@AgentAiDrive
Copy link
Owner

Summary

  • add a JSON config column to the Agent ORM model
  • introduce an Evidence model and connect it to Run records
  • update the workflow engine to record evidence payloads using attach_json

Testing

  • pytest

https://chatgpt.com/codex/tasks/task_e_6907136c6dbc83328ae3a8ddfc60e076

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 13 to +16
id = Column(Integer, primary_key=True, autoincrement=True)
name = Column(String(255), nullable=False, unique=True, index=True)
domain = Column(String(255), nullable=True)
config_json = Column(JSON, nullable=False, default=dict)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add migration for new Agent.config_json column

The new Agent.config_json field is declared as non‑nullable JSON without providing any migration or hot‑fix to add it to existing databases. All queries against Agent now select agents.config_json, so any installation running a pre‑existing SQLite file will start raising OperationalError: no such column: agents.config_json on startup (the project’s Base.metadata.create_all() calls will create new tables but will not add columns to existing ones). Please add an ALTER TABLE migration similar to other hotfix migrations or gate use of the column until the schema is upgraded.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants